On 8 October 2013 05:54, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote: > Michal Kazior <michal.kazior@xxxxxxxxx> writes: > >> If something failed along add_interface() setup it >> was possible to leak a vdev id, vdev and peer. >> >> This could end up with leaked FW state or FW crash >> (assuming add_interface() failure wasn't a result of >> a crash). >> >> Signed-off-by: Michal Kazior <michal.kazior@xxxxxxxxx> > > Then I apply this patch on top of current ath.git master branch (commit > 18fe0b53e76) interface up fails on the managed mode: > > $ sudo ip link set wlan1 up > RTNETLINK answers: Invalid argument > > Logs don't have anything special (the TX encap error was already > before): > > [ 1259.818863] ath10k: MSI-X didn't succeed (1), trying MSI > [ 1259.819298] ath10k_pci 0000:02:00.0: irq 49 for MSI/MSI-X > [ 1259.820055] ath10k: MSI interrupt handling > [ 1260.747877] ath10k: UART prints disabled > [ 1260.828219] ath10k: firmware 10.1.389 booted > [ 1260.837585] ath10k: htt target version 2.1 > [ 1260.838498] ath10k: Failed to set TX encap: -22 Ah. Right. I've tested this patch with main FW branch which supports TX encap command. The TX encap issue should be dealth with first. Michał -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
