On Tue, 2013-10-08 at 09:33 +0100, David Laight wrote: > > if (IS_ERR(key)) > > - return ERR_PTR(PTR_ERR(key)); > > + return ERR_CAST(key); > > I suspect the old code is a deliberate attempt to indicate that it > the error value that is being returned rather than the pointer. I was under the impression that's what ERR_CAST means. > Looking higher up that file there seems to be a fubar when setting > up the TKIP key. > It seems to put the same 6 bytes into every TID. > (I'm sure seq_len shouldn't be ignored either.0 Both are fine. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html