On Thu, 2013-10-03 at 07:20 +0000, Undekari, Sunil Dutt wrote: > Thanks Johannes for the review. > > >It seems you should validate that the length is even, and at least 2? > Can I know why the check for even/ atleast 2 is? Though I would > validate for a non zero length and return failure in the else, > considering a case where the TDLS peer advertises a single channel. > Shouldn't it suffice? Yes, if you look at the 802.11 spec you can know why. Hint: a single channel is advertised using 2 bytes. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html