Search Linux Wireless

Re: [PATCH RFT/RFC] b43: Add QOS support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2008-02-13 at 13:14 +0100, Michael Buesch wrote:
> On Wednesday 13 February 2008 13:07:53 Johannes Berg wrote:
> > 
> > > +	if (queue >= ARRAY_SIZE(wl->qos_params)) {
> > > +		/* Queue not available or don't support setting
> > > +		 * params on this queue. Return success to not
> > > +		 * confuse mac80211. */
> > > +		return 0;
> > > +	}
> > 
> > Is that really necessary? If so, I'll probably remove it when doing the
> > QoS rework, it shouldn't be, imho you should return an error if mac80211
> > tries to configure a queue >= hw.queues.
> 
> Yep, mac80211 walks the whole queue array without looking at hw->queues.
> I think this needs fixing in mac80211.

Ah. Yeah I already fixed that in my WIP QoS patch.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux