On Wed, Sep 25, 2013 at 04:42:15PM +0300, Luca Coelho wrote: > On Wed, 2013-09-25 at 08:23 -0500, Felipe Balbi wrote: > > On Wed, Sep 25, 2013 at 02:07:58PM +0300, Luca Coelho wrote: > > > On Wed, 2013-09-25 at 14:04 +0300, Luca Coelho wrote: > > > > When sending big binary blobs, it's generally better to send pull > > > > requests instead of patches. If you add the -p option when calling git > > > > pull-request, the text will include all the readable parts but will omit > > > > the binary stuff. > > > > > > > > Thank you very much for following up on this! > > > > > > Ah, and I forgot to say that you should update the WHENCE file > > > accordingly too. Check the wl12xx and wl18xx drivers for examples. > > > > I'll send a pull request, but how about this ? I don't think we can > > change the license. It seems like the other firmwares are using the > > older license, I'd argue those should be changed to the new one, but > > that's another discussion. > > Cool, in general it looks good! > > Though it would be nice to know if the same "new" license could be used > for all the firmwares to avoid almost identical licenses. well, i'm not a lawyer :-s > > diff --git a/WHENCE b/WHENCE > > index e66fea5..4e9e2ed 100644 > > --- a/WHENCE > > +++ b/WHENCE > > @@ -1705,6 +1705,19 @@ Licence: Redistributable. See LICENCE.tda7706-firmware.txt for details. > > > > -------------------------------------------------------------------------- > > > > +Driver: wl1251 - Texas Instruments 802.11 WLAN driver for WiLink4 chips > > + > > +File: ti-connectivity/wl1251-fw.bin > > +File: ti-connectivity/wl1251-nvs.bin > > Don't you have the firmware version number to add here with "Version:" > tags like the other ones? I think you can easily find the version by > running strings on the binary and grepping for "Rev" (at least with the > newer WiLinks, this works). Done :-) thanks for the tip. > > +Licence: See LICENCE.wl1251 for details. > > + > > +The driver expects to find the firmwares under a ti-connectivity subdirectory. > > +So if your system looks for firmwares in /lib/firmware, the firmwares for > > +wl12xx chips must be located in /lib/firmware/ti-connectivity/. > > It's a bit stupid that this was never changed in wl1251, but it still > expects the driver in the "root" firmwares directory (ie. > in /lib/firmware/wl1251-fw.bin, not > in /lib/firmware/ti-connectivity/wl1251-fw.bin). Maybe now is the right > time to change the driver appropriately to keep consistency? ;) alright, will do... -- balbi
Attachment:
signature.asc
Description: Digital signature
