Search Linux Wireless

Re: [PATCH 4/8 V2] rtlwifi: rtl8192_common: Fix smatch errors and warnings in rtl8192c/dm_common.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 09/16/2013 11:07 PM, Larry Finger wrote:

Smatch lists the following:
   CHECK   drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:551 rtl92c_dm_pwdb_monitor()
info: ignoring unreachable code.
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:551 rtl92c_dm_pwdb_monitor()
info: ignoring unreachable code.
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:870
rtl92c_dm_txpower_tracking_callback_thermalmeter() error: buffer overflow
'txpwr_level' 2 <= 2
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:870
rtl92c_dm_txpower_tracking_callback_thermalmeter() error: buffer overflow
'txpwr_level' 2 <= 2
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:882
rtl92c_dm_txpower_tracking_callback_thermalmeter() error: buffer overflow
'txpwr_level' 2 <= 2
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:883
rtl92c_dm_txpower_tracking_callback_thermalmeter() error: buffer overflow
'txpwr_level' 2 <= 2
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:891
rtl92c_dm_txpower_tracking_callback_thermalmeter() error: buffer overflow
'txpwr_level' 2 <= 2
drivers/net/wireless/rtlwifi/rtl8192c/dm_common.c:892
rtl92c_dm_txpower_tracking_callback_thermalmeter() error: buffer overflow
'txpwr_level' 2 <= 2

The unreachable code message is fixed by commenting out the code that follows
a return.

    You've commented out the whole function body, where is the *return* you're
talking about?

The return is in the middle of the function body just after the variable
declarations. It does not show in the diff listing, but it is there. What
should I do?

   Just describe what you really did, I guess.

Larry

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux