Search Linux Wireless

Re: [PATCH] zd1211rw: Fix beacon filter flags thinko

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2008-02-10 at 16:03 +0100, Michael Buesch wrote:
> We must not clear the FIF_BCN_PRBRESP_PROMISC bit in the
> new_flags. The zd-driver does support sending beacons and
> probe responses to the host. What the flag does is say "Send me
> all beacons and probe responses". And we actually do that. We always
> do that, so we ignore the case when the bit is disabled. But that is
> fine. But we must not clear the flag, as that tells mac80211 that
> we do not support passing beacons and probe responses to the stack.
> And that's not true.

Good explanation. Maybe it's needed with the filter flags defines/the
config_filter callback description?

> Signed-off-by: Michael Buesch <mb@xxxxxxxxx>

Acked-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>

> ---
> 
> Should probably go -stable, too.

Unnecessary, I don't think we currently ever test the flag in mac80211.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux