On Fri, 2008-02-08 at 16:36 -0800, Luis Carlos Cobo wrote:
> On Thu, 2008-02-07 at 01:53 +0100, Johannes Berg wrote:
> > > + if (!is_estab_plink(hdr->addr2, rx->dev)) {
> >
> > This would get to be something like
> >
> > if (sta->flags & STA_FLAG_MESH_LINK_ESTABLISHED)
> >
> > right?
>
> I probably can use just the AUTHORIZED flag.
Hm. The authorized flag basically says that it's possible to
send/receive non-eapol data frames to/from that station. I think you
shouldn't overload it, might not an implementation of secure peer links
need to be able to distinguish between different states? In any case,
adding a new flag is cheap and more self-explanatory imho.
> > I suppose you should be adding sta_info structs for each mesh peer and
> > set the AUTHORIZED flag on them. Is this what you were referring to in
> > the patch description?
>
> Right, and adding a pointer to a reduced mesh peer link structure with
> variables only needed for mesh (it would only be allocated for mesh
> interfaces).
Sounds good.
> Btw, I will also fix all the issues I'm not commenting on in this patch
> and the others. Thanks for you patience with me!
Well thanks for doing this work in the first place! :)
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
