On Tue, Sep 10, 2013 at 10:24 PM, Luca Coelho <luca@xxxxxxxxx> wrote: > On Tue, 2013-09-10 at 16:04 +0200, Eliad Peller wrote: >> On Tue, Sep 10, 2013 at 9:34 AM, Luca Coelho <luca@xxxxxxxxx> wrote: >> > On Tue, 2013-09-03 at 17:33 +0300, Eliad Peller wrote: >> >> From: Yair Shapira <yair.shapira@xxxxxx> >> >> >> >> We now disable elp sleep during plt mode to allow normal operation of >> >> plt tools such as calibrator. >> >> >> >> Having elp_sleep enabled during plt mode is actually not required and >> >> in fact it disrupt plt operations such as rx statistics etc. >> >> >> >> Signed-off-by: Yair Shapira <yair.shapira@xxxxxx> >> >> Signed-off-by: Eliad Peller <eliad@xxxxxxxxxx> >> >> --- >> > >> > I also had a comment internally about this one. Why do we need this? >> > AFAICT this would never happen in real life, since the firmware is not >> > even loaded at this point. Is there any real life situation where we >> > try to go into ELP while in PLT mode? >> > >> i'm not familiar with the whole plt process, but i guess some flows >> might indeed end up in elp (e.g. via wl1271_cmd_interrogate(), in >> order to read statistics) > > Well, I don't think this would ever happen. The PLT stuff is a > completely different firmware and, really, if it tries to go into ELP > mode it is a bug. > i can see the calibrator calls various WL1271_TM_CMD_TEST commands, so i guess they are likely to end up with ps_elp_sleep() calls (in wl1271_tm_cmd_test()). Eliad. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
