On Tue, Sep 10, 2013 at 12:15 PM, Luca Coelho <luca@xxxxxxxxx> wrote: > On Tue, 2013-09-10 at 11:11 +0200, Arik Nemtsov wrote: >> On Tue, Sep 10, 2013 at 9:47 AM, Luca Coelho <luca@xxxxxxxxx> wrote: >> > On Tue, 2013-09-03 at 17:34 +0300, Eliad Peller wrote: >> >> From: Igal Chernobelsky <igalc@xxxxxx> >> >> >> >> Send EAPOL frames with voice priority by setting TX_HW_ATTR_EAPOL_FRAME >> >> new bit in tx attribute. Sending EAPOL with voice priority fixes >> >> re-key timeout during heavy traffic issue. >> >> >> >> Signed-off-by: Igal Chernobelsky <igalc@xxxxxx> >> >> Signed-off-by: Eliad Peller <eliad@xxxxxxxxxx> >> >> --- >> > >> > This seems to be the same problem that Ben had and debugged by himself >> > [1]. Fixing this in hostapd/wpa_supplicant seems more appropriate? >> > >> > This patch seems to take an advantage of some sort of hack in the >> > firmware that will change the priority by itself when the >> > TX_HW_ATTR_EAPOL_GRAME bit is set. If we have a good reason to use this >> > patch, we need to take care of the firmware version as well. This >> > probably doesn't work with the latest published firmware. >> > >> > [1] http://mid.gmane.org/522E18E5.1020503@xxxxxxxxxxxxxxx >> >> I believe he only fixed one mode (AP - hostapd) but not the other (GO >> - wpa_supplicant). Anyway that's what we tested at the time. > > Okay, I didn't dig much into it. > > >> Anyway marking it as this level doesn't do any harm. You're right >> about the FW version though - it should be upstreamed first. > > Fair enough. If the firmware implements this, no reason why not use it. > But I'll wait for the new firmware before applying this. > this change is backward compatible, so there's no issue applying it as is. however, if you prefer waiting for a newer fw that's fine too. i'll add it to the waiting list :) Eliad. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
