On Tue, Sep 10, 2013 at 9:56 AM, Luca Coelho <luca@xxxxxxxxx> wrote: > On Tue, 2013-09-10 at 08:47 +0200, Arik Nemtsov wrote: >> On Tue, Sep 10, 2013 at 9:33 AM, Luca Coelho <luca@xxxxxxxxx> wrote: >> > On Tue, 2013-09-03 at 17:33 +0300, Eliad Peller wrote: >> >> From: Yair Shapira <yair.shapira@xxxxxx> >> >> >> >> Under this mode the chip is powered on including sdio >> >> but no FW is downloaded and run, interrupts are not enabled, etc... >> >> >> >> This mode is intended to allow RTTT to bridge sdio as a transport >> >> to the chip. >> >> >> >> Driver only provides sdio access using the dev_mem debugfs file. >> >> >> >> Some fixes done to the code that ensures that PLT mode and normal >> >> driver power mode (ifconfig/add_interface) are mutually excluded. >> >> >> >> Signed-off-by: Yair Shapira <yair.shapira@xxxxxx> >> >> Signed-off-by: Eliad Peller <eliad@xxxxxxxxxx> >> >> --- >> > >> > I had some comments to this patch internally while I was still at TI. >> > Namely, I asked why do we need a new way of doing this if this is >> > already possible via debugsfs (using the gpio_power file)? >> >> Are you commenting on the correct patch? Seems this is just a patch to >> prevent "ifconfig up" during PLT mode.. > > Yes, I'm commenting on the right patch. It allows the chip power > (namely the WLAN_EN GPIO pin) to be set directly, without loading the > firmware and doing other initialization stuff. This can already be > controlled via the gpio_power debugfs file. I've used that a bunch of > times, including with the RTTT tool. > > Okay, this patch has a few more protections (eg. not allowing an > interface to be added while the chip is powered in this way), but this > could also be added on top of the existing implementation. > i guess this just a bit "cleaner" (similar to the way PLT is used). the gpio_power debugfs only toggles the gpio power, without changing the driver mode, so adding similar protections will be more complicated. Eliad. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
