On Tue, 2013-09-03 at 17:34 +0300, Eliad Peller wrote:
> From: Victor Goldenshtein <victorg@xxxxxx>
>
> Remove scan debug dumps which are rarely used.
> Make scan debug prints more clear and short.
>
> Signed-off-by: Victor Goldenshtein <victorg@xxxxxx>
> Signed-off-by: Eliad Peller <eliad@xxxxxxxxxx>
> ---
This is fine, these dumps were used when the firmware scan APIs were
changing all the time and we were having lots of problems following it.
It can be removed now to reduce excessive output.
Some nitpicks below.
[...]
> diff --git a/drivers/net/wireless/ti/wlcore/scan.c b/drivers/net/wireless/ti/wlcore/scan.c
> index f407101..bbe0bc4 100644
> --- a/drivers/net/wireless/ti/wlcore/scan.c
> +++ b/drivers/net/wireless/ti/wlcore/scan.c
> @@ -174,17 +174,7 @@ wlcore_scan_get_channels(struct wl1271 *wl,
> /* if radar is set, we ignore the passive flag */
> (radar ||
> !!(flags & IEEE80211_CHAN_PASSIVE_SCAN) == passive)) {
> - wl1271_debug(DEBUG_SCAN, "band %d, center_freq %d ",
> - req_channels[i]->band,
> - req_channels[i]->center_freq);
> - wl1271_debug(DEBUG_SCAN, "hw_value %d, flags %X",
> - req_channels[i]->hw_value,
> - req_channels[i]->flags);
> - wl1271_debug(DEBUG_SCAN, "max_power %d",
> - req_channels[i]->max_power);
> - wl1271_debug(DEBUG_SCAN, "min_dwell_time %d max dwell time %d",
> - min_dwell_time_active,
> - max_dwell_time_active);
> +
>
Unnecessary extra line here.
[...]
> @@ -222,6 +212,18 @@ wlcore_scan_get_channels(struct wl1271 *wl,
> *n_pactive_ch);
> }
>
> + wl1271_debug(DEBUG_SCAN, "freq %04d, ch. %03d, flags 0x%02X, power %02d, min/max_dwell %02d/%02d%s%s",
Left-padding with zeros is quite ugly with the decimals here.
--
Luca.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
