Search Linux Wireless

Re: bcma problem on x86_64

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/06/2013 06:37 PM, Hauke Mehrtens wrote:
On 09/06/2013 05:25 PM, Arend van Spriel wrote:
On 09/06/2013 11:05 AM, Arend van Spriel wrote:
On 09/06/2013 10:05 AM, Rafał Miłecki wrote:
Hi,

2013/9/5 Arend van Spriel <arend@xxxxxxxxxxxx>:
Since 3.11-rc4 I am seeing a problem with bcma on x64 (see attached
log). I
thought I misconfigured my setup, but just upgraded to 3.11 and I am
still
seeing the same issue. Did you have any reports like this?

Unfortunately I wasn't testing final 3.11 with x86_64, I'll give it a
try over the weekend.


I am bisecting. Will let you know when I find something.

Bisect points to:

fd4edf197544bae1c77d84bad354aa7ce1d08ce1 is the first bad commit
commit fd4edf197544bae1c77d84bad354aa7ce1d08ce1
Author: Hauke Mehrtens <hauke@xxxxxxxxxx>
Date:   Mon Jul 15 13:15:08 2013 +0200

     bcma: fix handling of big addrl

     The return value of bcma_erom_get_addr_desc() is a unsigned value
and it
     could wrap around in the two complement writing. This happens for one
     core in the BCM4708 SoC.

     Signed-off-by: Hauke Mehrtens <hauke@xxxxxxxxxx>
     Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx>

It is probably caused by using IS_ERR_VALUE() macro which does a
unsigned long cast, which gives different results on 64-bit platform.

This patch was submitted upstream yesterday by Dave for 3.12-rc1.

Regards,
Arend

Hi Arend,

Thanks for spotting this. This commit is not in final 3.11, otherwise
I would have suspected it before.

Yeah. It will need to be fixed for 3.12 after the merge window.

Could you please try the attached patch.

Just tried my own patch, which essentially does the same (not using a macro).

So you may add
Acked-by: or Tested-by: Arend van Spriel <arend@xxxxxxxxxxxx>
Whatever you think is most appropriate.

Regards,
Arend

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux