Bartosz Markowski <bartosz.markowski@xxxxxxxxx> writes:
> The WMI_REQUEST_PEER_STAT command with latst (1.0.0.716) FW
> can return per-VDEV statistics. Using debugfs we can fetch this info now.
>
> This is a backward compatible change. In case of older FW the VDEV
> statistics are simply not returned.
>
> Signed-off-by: Bartosz Markowski <bartosz.markowski@xxxxxxxxx>
[...]
> if (num_peer_stats) {
> - struct wmi_peer_stats *peer_stats;
> struct ath10k_peer_stat *s;
> + struct wmi_peer_stats_1 *peer_stats_1;
> + struct wmi_peer_stats_2 *peer_stats_2;
>
> stats->peers = num_peer_stats;
>
> for (i = 0; i < num_peer_stats; i++) {
> - peer_stats = (struct wmi_peer_stats *)tmp;
> + peer_stats_1 = (struct wmi_peer_stats_1 *)tmp;
You still have this evil cast here which assumes struct wmi_peer_stats_1
starts with the same content as _2. It's better to spell that out in the
code, for example like this:
if (test_bit(ATH10K_FW_FEATURE_VDEV_STATS, ar->fw_features)) {
peer_v2 = (struct wmi_peer_stats_v2 *)tmp;
peer_stats = &peer_v2->common;
tmp += sizeof(*peer_v2);
} else {
peer_v1 = (struct wmi_peer_stats_v1 *)tmp;
peer_stats = &peer_v1->common;
tmp += sizeof(*peer_v1);
}
> +struct wmi_peer_stats_1 {
struct wmi_peer_stats_v1
> +struct wmi_peer_stats_2 {
struct wmi_peer_stats_v2
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
