Search Linux Wireless

Re: [PATCH] rt2x00: Add new USB ID to rt2500usb

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 10, 2008 at 10:31 AM, Michael Buesch <mb@xxxxxxxxx> wrote:
> On Sunday 10 February 2008 11:21:57 Ivo van Doorn wrote:
>  >
>  > Signed-off-by: Ivo van Doorn <IvDoorn@xxxxxxxxx>
>  > ---
>  > John, please send this patch to the 2.6.24/2.6.25 stable trees.
>  > It is already present in the wireless-2.6 tree queued for 2.6.26.
>  >
>  >  drivers/net/wireless/rt2x00/rt2500usb.c |    2 +-
>  >  1 files changed, 1 insertions(+), 1 deletions(-)
>  >
>  > diff --git a/drivers/net/wireless/rt2x00/rt2500usb.c b/drivers/net/wireless/rt2x00/rt2500usb.c
>  > index cba7f57..c4a6ab4 100644
>  > --- a/drivers/net/wireless/rt2x00/rt2500usb.c
>  > +++ b/drivers/net/wireless/rt2x00/rt2500usb.c
>  > @@ -1871,11 +1871,11 @@ static struct usb_device_id rt2500usb_device_table[] = {
>  >       /* Hercules */
>  >       { USB_DEVICE(0x06f8, 0xe000), USB_DEVICE_DATA(&rt2500usb_ops) },
>  >       /* Melco */
>  > +     { USB_DEVICE(0x0411, 0x005e), USB_DEVICE_DATA(&rt2500usb_ops) },
>  >       { USB_DEVICE(0x0411, 0x0066), USB_DEVICE_DATA(&rt2500usb_ops) },
>  >       { USB_DEVICE(0x0411, 0x0067), USB_DEVICE_DATA(&rt2500usb_ops) },
>  >       { USB_DEVICE(0x0411, 0x008b), USB_DEVICE_DATA(&rt2500usb_ops) },
>  >       { USB_DEVICE(0x0411, 0x0097), USB_DEVICE_DATA(&rt2500usb_ops) },
>  > -
>  >       /* MSI */
>  >       { USB_DEVICE(0x0db0, 0x6861), USB_DEVICE_DATA(&rt2500usb_ops) },
>  >       { USB_DEVICE(0x0db0, 0x6865), USB_DEVICE_DATA(&rt2500usb_ops) },
>
>  I'm unsure on how this is an actual _fix_ that we need in a stable kernel.
>  We always handled adding IDs as features.

Please forgive me for stepping in this apparently already closed discussion.

Why is supporting a new USB ID considered a feature, when the users
are probably ok with it (it works) and no changes are added to the
code?

Luis Correia
rt2x00 project admin

>
>  --
>  Greetings Michael.
>
>
> -
>  To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
>  the body of a message to majordomo@xxxxxxxxxxxxxxx
>  More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux