Hi Julian,
Thanks for the review.
> On Tue, Aug 20, 2013 at 9:12 PM, Emmanuel Grumbach
> <emmanuel.grumbach@xxxxxxxxx> wrote:
>> SMPS code checks all over the place that the vif is
>> BSS. Remove that constraint and allow SMPS for AP too.
>>
>> Provide dummy implementation that will be used for
>> further patches.
>>
>> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@xxxxxxxxx>
>> ---
>> net/mac80211/cfg.c | 15 ++++++++++++---
>> net/mac80211/debugfs_netdev.c | 24 +++++++++++++++---------
>> net/mac80211/ht.c | 38 ++++++++++++++++++++++++++++----------
>> net/mac80211/ieee80211_i.h | 13 ++++++++++---
>> net/mac80211/iface.c | 2 ++
>> net/mac80211/mlme.c | 2 +-
>> 6 files changed, 68 insertions(+), 26 deletions(-)
>>
>> diff --git a/net/mac80211/debugfs_netdev.c b/net/mac80211/debugfs_netdev.c
>> index e601c9f..7609e47 100644
>> --- a/net/mac80211/debugfs_netdev.c
>> +++ b/net/mac80211/debugfs_netdev.c
>> @@ -245,12 +248,15 @@ static const char *smps_modes[IEEE80211_SMPS_NUM_MODES] = {
>> static ssize_t ieee80211_if_fmt_smps(const struct ieee80211_sub_if_data *sdata,
>> char *buf, int buflen)
>> {
>> - if (sdata->vif.type != NL80211_IFTYPE_STATION)
>> - return -EOPNOTSUPP;
>> -
>> - return snprintf(buf, buflen, "request: %s\nused: %s\n",
>> - smps_modes[sdata->u.mgd.req_smps],
>> - smps_modes[sdata->smps_mode]);
>> + if (sdata->vif.type == NL80211_IFTYPE_STATION)
>> + return snprintf(buf, buflen, "request: %s\nused: %s\n",
>> + smps_modes[sdata->u.mgd.req_smps],
>> + smps_modes[sdata->smps_mode]);
>> + if (sdata->vif.type == NL80211_IFTYPE_AP)
>> + return snprintf(buf, buflen, "request: %s\nused: %s\n",
>> + smps_modes[sdata->u.ap.req_smps],
>> + smps_modes[sdata->smps_mode]);
>> + return -EINVAL;
>
> Do you intend to change the return value for this function when we
> can't do SMPS from -EOPNOTSUPP to -EINVAL?
You are right - v2 on the way with other comments I got internally.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
