Search Linux Wireless

Re: [PATCH 12/12] brcmsmac: add support for BCM4313 iPA variant

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2013-08-20 at 16:00 +0200, Arend van Spriel wrote:
> This patch completes the changes needed for supporting the
> iPA variant cards of the BCM4313 wireless chipset.
[]
> diff --git a/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_lcn.c b/drivers/net/wireless/brcm80211/brcmsmac/phy/phy_lcn.c
[]
> @@ -1826,6 +1826,17 @@ wlc_lcnphy_radio_2064_channel_tune_4313(struct brcms_phy *pi, u8 channel)
>  		write_radio_reg(pi, RADIO_2064_REG038, 3);
>  		write_radio_reg(pi, RADIO_2064_REG091, 7);
>  	}
> +
> +	if (!(pi->sh->boardflags & BFL_FEM)) {
> +		u8 reg038[14] = {0xd, 0xe, 0xd, 0xd, 0xd, 0xc,
> +			0xa, 0xb, 0xb, 0x3, 0x3, 0x2, 0x0, 0x0};

static const would reduce the object size.

> +		write_radio_reg(pi, RADIO_2064_REG02A, 0xf);
> +		write_radio_reg(pi, RADIO_2064_REG091, 0x3);
> +		write_radio_reg(pi, RADIO_2064_REG038, 0x3);
> +
> +		write_radio_reg(pi, RADIO_2064_REG038, reg038[channel - 1]);

Does anything limit channel to < 15?

There seem to be an awful lot of magic numbers
in the patch.


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux