Hi John, Hi Marc, On Tue, Aug 20, 2013 at 11:01 AM, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote: > On 08/16/2013 09:39 PM, Marc Kleine-Budde wrote: >> From: Helmut Schaa <helmut.schaa@xxxxxxxxxxxxxx> >> >> ath9k_htc adds padding between the 802.11 header and the payload during >> TX by moving the header. When handing the frame back to mac80211 for TX >> status handling the header is not moved back into its original position. >> This can result in a too small skb headroom when entering ath9k_htc >> again (due to a soft retransmission for example) causing an >> skb_under_panic oops. >> >> Fix this by moving the 802.11 header back into its original position >> before returning the frame to mac80211 as other drivers like rt2x00 >> or ath5k do. >> >> Reported-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> >> Signed-off-by: Helmut Schaa <helmut.schaa@xxxxxxxxxxxxxx> >> Tested-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> >> Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> >> --- >> Hello Helmut, >> >> I've change the patch a bit, I've used ieee80211_get_hdrlen_from_skb() instead >> of open coding it. >> >> Tested in ARMv5 with USB device >> "ID 0cf3:7015 Atheros Communications, Inc. TP-Link TL-WN821N v3 802.11n [Atheros AR7010+AR9287]" >> for four weeks. Without that patch the kernel oopes after about one week. >> >> I think this is a candidate for stable, can you add stable to Cc? > > ping Sorry, completely forgot about this patch. You're right, this is indeed a stable candidate. John, could you please add "Cc: stable@xxxxxxxxxxxxxxx" when applying this to your tree? Thanks, Helmut -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
