On Thu, Aug 15, 2013 at 3:03 PM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
>> @@ -2872,6 +2872,11 @@ void ieee80211_csa_finalize_work(struct work_struct *work)
>> if (WARN_ON(err < 0))
>> return;
>>
>> + if (!local->use_chanctx) {
>> + local->_oper_chandef = local->csa_chandef;
>> + ieee80211_hw_config(local, 0);
>> + }
>
> I don't really understand this part - I think you should add some
> documentation or something?
Basically I removed this chunk of code from
ieee80211_vif_change_channel() and put it here - a bit later in the AP
CSA flow.
I don't think it does any harm.
>
>> @@ -453,11 +453,6 @@ int ieee80211_vif_change_channel(struct ieee80211_sub_if_data *sdata,
>> chanctx_changed |= IEEE80211_CHANCTX_CHANGE_CHANNEL;
>> drv_change_chanctx(local, ctx, chanctx_changed);
>>
>> - if (!local->use_chanctx) {
>> - local->_oper_chandef = *chandef;
>> - ieee80211_hw_config(local, 0);
>> - }
>
> I really don't like it either - this was here so that no other code
> really needed to be worried about non-chanctx drivers.
Well right now ieee80211_chswitch_work() takes care of it, and does
something a bit different there to accommodate the legacy behavior -
if the chan_switch op is defined, ieee80211_hw_config is not called.
Would you prefer that ieee80211_vif_change_channel() handle all this,
checking interface type to do the right thing?
>
>> @@ -1180,17 +1196,27 @@ ieee80211_sta_process_chanswitch(struct ieee80211_sub_if_data *sdata,
>> }
>>
>> ifmgd->flags |= IEEE80211_STA_CSA_RECEIVED;
>> + sdata->vif.csa_active = true;
>
> I don't think we can just do this - this isn't going to result in good
> behaviour for multi-vif drivers and in particular I'm pretty sure with
> the MVM driver this would result in bad behaviour.
>
> If you really want to do this I think it needs to be optional.
I only added it since the current implementation of
ieee80211_vif_change_channel() bails if it's false. That said, I'm not
sure what's wrong here. This setting is per-vif.
>
> Also the documentation for the chanctx channel change probably needs to
> be updated, etc.
Is there any current documentation? The AP CSA patches by Simon didn't
have any IIRC.
I guess I'm not sure what's special here, we just replace the chandef
and that's it.
Arik
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
