On Tue, Aug 13, 2013 at 12:35:16AM +0100, Malcolm Priestley wrote: > On Mon, 2013-08-12 at 16:09 -0700, Greg KH wrote: > > On Tue, Aug 13, 2013 at 12:07:15AM +0100, Malcolm Priestley wrote: > > > On Mon, 2013-08-12 at 14:59 -0700, Greg KH wrote: > > > > On Mon, Aug 05, 2013 at 09:04:54PM +0100, Malcolm Priestley wrote: > > > > > All structure members of BEACON_BUFFER/TX_BUFFER should be packed. > > > > > > > > Why? > > > > > > Only the first 4 members of these structures are live. > > > > > > The forth member is referenced at run-time by packed structures. > > > typedef struct tagSTxBufHead > > > typedef struct tagSTxShortBufHead > > > in desc.h > > > > > > If these structures are not packed the alignment of these members > > > will be wrong. > > > > Then say all of this in the patch please :) > > > > > > > > > > What happens if they are not? > > > The driver does not work. > > > > How is it working today without this change? > Well for *me* it works. > > It appears the structure is packed anyway. > > But is this guaranteed? > > Anyway, do you want me to resend the patch. > Yes, please do, with this added information, and all other patches from you that I did not apply, due to me not accepting this one. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
