Search Linux Wireless

Re: [patch] Hostap: copying wrong data prism2_ioctl_giwaplist()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Here I must insert the obligatory question:

	Does anyone actually still use the hostap driver??

John

On Fri, Aug 09, 2013 at 12:52:31PM +0300, Dan Carpenter wrote:
> We want the data stored in "addr" and "qual", but the extra ampersands
> mean we are copying stack data instead.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> ---
> Static checker stuff.  Untested.  Should probably be applied to -stable
> as well.
> 
> diff --git a/drivers/net/wireless/hostap/hostap_ioctl.c b/drivers/net/wireless/hostap/hostap_ioctl.c
> index ac07473..e509030 100644
> --- a/drivers/net/wireless/hostap/hostap_ioctl.c
> +++ b/drivers/net/wireless/hostap/hostap_ioctl.c
> @@ -523,9 +523,9 @@ static int prism2_ioctl_giwaplist(struct net_device *dev,
>  
>  	data->length = prism2_ap_get_sta_qual(local, addr, qual, IW_MAX_AP, 1);
>  
> -	memcpy(extra, &addr, sizeof(struct sockaddr) * data->length);
> +	memcpy(extra, addr, sizeof(struct sockaddr) * data->length);
>  	data->flags = 1; /* has quality information */
> -	memcpy(extra + sizeof(struct sockaddr) * data->length, &qual,
> +	memcpy(extra + sizeof(struct sockaddr) * data->length, qual,
>  	       sizeof(struct iw_quality) * data->length);
>  
>  	kfree(addr);
> 

-- 
John W. Linville		Someday the world will need a hero, and you
linville@xxxxxxxxxxxxx			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux