Michal Kazior <michal.kazior@xxxxxxxxx> writes:
> On 8 August 2013 11:05, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote:
>> This debug print is good to have, but with the new htt version it would
>> be good to print it always using the info level. For example, can we add
>> it to the same line with "firmware %s booted" string?
>
> HTT target version is not known when firmware boots up. It's not known
> until everything other (HTC, WMI) is set up. We then send a version
> request command and we get a response.
Oh, missed that.
> We need to print it in a separate line.
Or could we print the "firmware booted" message later?
>> (Please take into account that the info messages still need to be
>> compact, by default they should not be longer than five lines or so.)
>>
>>> + if (htt->target_version_major != 2 &&
>>> + htt->target_version_major != 3) {
>>> ath10k_err("htt major versions are incompatible!\n");
>>> return -ENOTSUPP;
>>> }
>>
>> Print the htt version in the error message as well?
>
> Target version is printed in ath10k_dbg() now. If we change that to
> ath10k_info() I don't see any reason to print the version again on
> error.
Frequently users just copy the error message, that's why it's better to
have the firmware's htt version in the error message as well.
> We may want to print the list of supported HTT major version numbers
> though?
That's good to have as well, at least in the debug messages.
--
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
