> +/* plink is short for peer link */
> +struct mesh_plink {
> + u8 ha[ETH_ALEN]; /* Hardware address */
> + __le16 llid; /* Local link ID */
> + __le16 plid; /* Peer link ID */
> + __le16 reason; /* Buffer for cancel reason on HOLDING state */
> + u8 retries; /* Retries in establishment */
> + enum plink_state state;
> + u32 timeout;
> + struct timer_list timer;
> + bool ignore_timer;
> + spinlock_t state_lock; /* For peer_state reads / updates and other
> + updates in the structure. Ensures robust
> + trasitions for the peerlink FSM */
typo: transitions, what does FSM mean? Also, using kernel-doc instead of
inline comments would be appreciated for when I get around to writing
documentation again.
> +#define MESH_PATH_ACTIVE 1
> +#define MESH_PATH_RESOLVING 2
> +#define MESH_PATH_DSN_VALID 4
> +#define MESH_PATH_FIXED 8
> +#define MESH_PATH_DELETE 16
> +#define MESH_PATH_RESOLVED 32
You could use an enum and kernel-doc to explain these, also the BIT()
might make sense.
> +struct mesh_path {
> +struct mesh_table {
> +struct rmc_entry {
Similarly, kernel-doc would be nice.
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
