On 7 August 2013 08:59, Kalle Valo <kvalo@xxxxxxxxxxxxxxxx> wrote: > Janusz Dziedzic <janusz.dziedzic@xxxxxxxxx> writes: > >> Setup UAPSD peer rate control (FW flag) >> correctly. >> >> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@xxxxxxxxx> > > This doesn't answer the question "Why?". I have now added a section in > the wiki about what the commit log should contain. Hopefully that helps. > > Submitting patches > > Send patches to the mailing lists below. Kalle Valo reviews the patches > within the next few days and, if they are ok, commits them to ath.git. > > To: ath10k@xxxxxxxxxxxxxxxxxxx > Cc: linux-wireless@xxxxxxxxxxxxxxx > > Preferably use ath.git master as the baseline for patches. Other trees > can be used as well, but then the chances of conflicts are higher. > > Guidelines for patches: > > * MUST be compiler warning free. > > * MUST be sparse warning free. > > * Commit log MUST not be empty. > > * The commit log MUST answer the question "Why?": > > * Describe the motivation behind the bug. > > * How does it change the functionality from user's point of view? > > * Does it fix a bug? If it does, please describe the bug (doesn't need > to be long). Also if there's a public bug report add a link to the > bug report. > > * If others have reported the issue commit log SHOULD use Reported-by: > and Tested-by: tags. > > * SHOULD be checkpatch clean: > > * FIXME: add checkpatch example with correct arguments > > * Patches SHOULD be sent with git send-email tool. > > * Patchsets SHOULD contain no more than 12 patches. > > The terminology is from http://www.ietf.org/rfc/rfc2119.txt > > http://wireless.kernel.org/en/users/Drivers/ath10k#Submitting_patches > > Please comment. > Setup UAPSD peer/peer rate flags correctly. WMI_RC_UAPSD_FLAG is a peer rate capabilities flag and should not be set as a peer flag. BTW this don't fix any known bug yet, just found during UAPSD check. BR Janusz -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
