Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: > On Wed, 2013-07-17 at 07:10 +0300, Kalle Valo wrote: >> Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: >> >> > We have beacon filtering (to reduce host wakeups) in our device, >> > but for some measurement/debug purposes we need to turn it off. >> >> TBH I'm not really fond of this. I'm not really sure what's the use >> case but first this sounded a like a factory test for me, not something >> which a regular user would want to do. Sure, that's good to do. I'm just worried that if we add a new command to enable/disable each small feature we will have a lot of commands in nl80211. But I guess that's not a problem as you are the maintainer anyway :) But I do see benefits from this, so I guess in the end this is good to have. It would be nice if someone would add a similar command for BT coexistance as well, that always seems to be a common source of problems. > Yeah, in a way that's true. FWIW, we could also connect it to testmode > and not worry about it for upstream, but it seemed that others might > want/need similar functionality. > >> Can't we connect this to power save? When disabling power save we could >> also disable beacon filtering and would not need a separate command. > > I'm not so sure that's a good idea. While superficially beacon filtering > is related to saving power, it's really a different thing - it's about > CPU/host power while powersave is about device power (RX chains etc.) > Connecting them, in particular where disabling beacon filtering isn't > even supported by all devices, doesn't really seem like a good idea, > particularly not for any tool that would require such functionality. Makes sense. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
