Search Linux Wireless

Re: [PATCH 1/1] mac80211: fix mis-match in {test,set}_bit qdisc_pool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 06, 2008 at 01:36:53AM +0200, Tomas Winkler wrote:
> On Feb 5, 2008 10:54 PM, John W. Linville <linville@xxxxxxxxxxxxx> wrote:
> > On Sun, Feb 03, 2008 at 11:54:38PM +0200, Tomas Winkler wrote:
> > > From: Ron Rindjunsky <ron.rindjunsky@xxxxxxxxx>
> > >
> > > This patch fixes a mis-match in {test,set}_bit for qdisc_pool created by
> > > the move to an array of bits.
> > >
> > > Signed-off-by: Ron Rindjunsky <ron.rindjunsky@xxxxxxxxx>
> > > Signed-off-by: Tomas Winkler <tomas.winkler@xxxxxxxxx>
> >
> >   CC [M]  net/mac80211/wme.o
> > net/mac80211/wme.c: In function 'wme_qdiscop_enqueue':
> > net/mac80211/wme.c:161: warning: passing argument 2 of 'constant_test_bit' makes pointer from integer without a cast
> > net/mac80211/wme.c:161: warning: passing argument 2 of 'variable_test_bit' makes pointer from integer without a cast
> > net/mac80211/wme.c:194: warning: passing argument 2 of 'constant_test_bit' makes pointer from integer without a cast
> > net/mac80211/wme.c:194: warning: passing argument 2 of 'variable_test_bit' makes pointer from integer without a cast
> > net/mac80211/wme.c: In function 'wme_qdiscop_dequeue':
> > net/mac80211/wme.c:275: warning: passing argument 2 of 'constant_test_bit' makes pointer from integer without a cast
> > net/mac80211/wme.c:275: warning: passing argument 2 of 'variable_test_bit' makes pointer from integer without a cast
> > net/mac80211/wme.c: In function 'wme_qdiscop_init':
> > net/mac80211/wme.c:399: warning: passing argument 2 of 'set_bit' makes pointer from integer without a cast
> > net/mac80211/wme.c: In function 'ieee80211_ht_agg_queue_add':
> > net/mac80211/wme.c:660: warning: passing argument 2 of 'test_and_set_bit' makes pointer from integer without a cast
> > net/mac80211/wme.c:673: error: subscripted value is neither array nor pointer
> > net/mac80211/wme.c: In function 'ieee80211_ht_agg_queue_remove':
> > net/mac80211/wme.c:693: warning: passing argument 2 of 'clear_bit' makes pointer from integer without a cast
> > make[1]: *** [net/mac80211/wme.o] Error 1
> > make: *** [net/mac80211/] Error 2
> >
> > Am I missing something?
> 
> This patch should fix warning that was caused Ron's patch
> 
> 'adjustable number of bits for qdisc pool'

I don't see a warning w/o it -- only build breakage w/ it.

-- 
John W. Linville
linville@xxxxxxxxxxxxx
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux