On 2013-07-15 2:50 PM, Joe Perches wrote: > On Mon, 2013-07-15 at 14:35 +0200, Felix Fietkau wrote: >> When priv_sta == NULL, mi->prev_sample is dereferenced too early. Move >> the assignment further down, after the rate_control_send_low call. >> >> Reported-by: Krzysztof Mazur <krzysiek@xxxxxxxxxxxx> >> Cc: stable@xxxxxxxxxxxxxxx # 3.10 >> Signed-off-by: Felix Fietkau <nbd@xxxxxxxxxxx> > > Why should this be marked for stable? > > It's a local reference only, it's not used. > > It's like suggesting that all the initialized > automatics should not be set until after > rate_control_set_low is called. mi is set to priv_sta. It can be NULL. The case of priv_sta==NULL is caught by rate_control_send_low and causes it to bail out. - Felix -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
