Search Linux Wireless

Re: [PATCH] brcmsmac: Further reduce log spam from tx phy messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/12/2013 02:00 PM, Joe Perches wrote:
On Fri, 2013-07-12 at 10:55 -0400, John Greene wrote:
Relegate 2 phy messages to debug status as they create excessive
log spam, noted in multiple bugzillas for brcmsmac v3.8 and up.

Hi John,

Just trivia:

diff --git a/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c b/drivers/net/wireless/brcm80211/brcmsmac/ampdu.c
[]
@@ -928,7 +928,7 @@ brcms_c_ampdu_dotxstatus_complete(struct ampdu_info *ampdu, struct scb *scb,
[]
-			brcms_err(wlc->hw->d11core,
+			brcms_dbg_ht(wlc->hw->d11core,
  				  "%s: ampdu tx phy error (0x%x)\n",
  				  __func__, txs->phyerr);

Please keep the indentation of the arguments of
the same statement aligned to the open parenthesis.

diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c b/drivers/net/wireless/brcm80211/brcmsmac/main.c
[]
@@ -882,7 +882,7 @@ brcms_c_dotxstatus(struct brcms_c_info *wlc, struct tx_status *txs)
[]
-		brcms_err(wlc->hw->d11core, "phyerr 0x%x, rate 0x%x\n",
+		brcms_dbg_tx(wlc->hw->d11core, "phyerr 0x%x, rate 0x%x\n",
  			  txs->phyerr, txh->MainRates);

Here too.


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Thanks Joe. My oversight. I wish the checkpatch flagged this stuff. I'll fix this and post v2.
--
John Greene

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux