On Sat, 2013-06-29 at 15:58 -0700, greearb@xxxxxxxxxxxxxxx wrote:
> From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
>
> Should help better debug dodgy APs and such.
This isn't a bad idea, but I think instead of storing the message:
> @@ -110,6 +110,7 @@ struct ieee80211_bss {
>
> /* Keep track of what bits of information we have valid info for. */
> u8 valid_data;
> + char corrupt_elems_msg[80];
you should store a "what's bad" type field and the broken IE number or
so, to reduce memory usage
> @@ -4341,8 +4341,8 @@ int ieee80211_mgd_assoc(struct ieee80211_sub_if_data *sdata,
> corrupt_type = "beacon";
> } else if (bss->corrupt_data & IEEE80211_BSS_CORRUPT_PROBE_RESP)
> corrupt_type = "probe response";
> - sdata_info(sdata, "associating with AP with corrupt %s\n",
> - corrupt_type);
> + sdata_info(sdata, "associating with AP with corrupt %s, reason: %s\n",
> + corrupt_type, bss->corrupt_elems_msg);
and only actually format the message here. That also reduces overhead
during beacon/probe response processing.
> + snprintf(elems->parse_err_msg,
> + sizeof(elems->parse_err_msg),
> + "seen id: %i already", id);
Your snprintf() usage is also unsafe.
johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
