On Fri, 2013-07-05 at 09:59 +1200, Sam Bristow wrote: > 'make htmldocs' was generating a warning about a missing parameter description > for gfp. > > Earlier patch was missing my signed-off-by line... > Signed-off-by: Sam Bristow <sam.bristow@xxxxxxxxx> > --- You have a typo in the patch subject (it was not there in your previous version ;). Also, you shouldn't add explanations about the different versions of the patch in the commit message (in you case the "Earlier patch was missing my signed-off-by line..." text). If you want to add this kind of comments, add it after the "---" under the Signed-of tags. One more thing, it's a good idea to use [PATCH v2] when you're sending a second version of the same patch. That can be easily done with git format-patch (and also with git send-email) by using an argument like this: --subject-prefix="PATCH v2" -- Luca. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html