Search Linux Wireless

Re: [RFC] mac80211: add rate to ieee80211_tx_status

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Feb 4, 2008 10:46 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
>
> > diff --git a/include/net/mac80211.h b/include/net/mac80211.h
> > index 460da54..a700ea6 100644
> > --- a/include/net/mac80211.h
> > +++ b/include/net/mac80211.h
> > @@ -342,6 +342,7 @@ enum ieee80211_tx_status_flags {
> >   *
> >   * @control: a copy of the &struct ieee80211_tx_control passed to the driver
> >   *   in the tx() callback.
> > + * @rate: rate at which the packet was actually transmitted
> >   * @flags: transmit status flags, defined above
> >   * @retry_count: number of retries
> >   * @excessive_retries: set to 1 if the frame was retried many times
> > @@ -356,6 +357,7 @@ enum ieee80211_tx_status_flags {
> >   */
> >  struct ieee80211_tx_status {
> >       struct ieee80211_tx_control control;
> > +     struct ieee80211_rate rate;
>
> Shouldn't that rather be a rate pointer? Seems a bit odd to me to copy
> that information. Felix, could this help you as well?

Where would be this pointer allocated? TX response is not the same
flow as TX where we keep it on the stack. It's will be very error
prone to be outside tx_status. From concept perspective you already
have all transimission information in that structure.
For iwlwifi I actually need only u32 value but I was looking for
something more general even it's a little pain.
I'm not sure but I guess we may as well separate ieee80211_tx_control
form ieee80211_tx_status as they carry different information

Thanks
Tomas

> johannes
>
-
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux