On 07/02/2013 09:24 PM, Shuah Khan wrote: [...] >>> +#ifdef CONFIG_PM >>> +/* Power Management Hooks */ >>> +static const struct dev_pm_ops mwifiex_pcie_pm_ops = { >>> + .suspend = mwifiex_pcie_suspend, >>> + .resume = mwifiex_pcie_resume, >>> +}; >>> +#endif >>> + >> >> Is it intended that you do not use SIMPLE_DEV_PM_OPS() like most of the >> other wifi drivers? > > So the reason for this is SIMPLE_DEV_PM_OPS() is defined only when > CONFIG_PM_SLEEP is enabled. This driver doesn't defines suspend and > resume when CONFIG_PM is enabled and I didn't want to change that. Hope > that helps understand why I didn't use SIMPLE_DEV_PM_OPS() Change the ifdefs to CONFIG_PM_SLEEP and use SIMPLE_DEV_PM_OPS. The driver does not support runtime PM. - Lars -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html