On Thu, Jun 27, 2013 at 04:31:29PM +0200, Johannes Berg wrote: > On Thu, 2013-06-27 at 16:30 +0200, Johannes Berg wrote: > > On Thu, 2013-06-27 at 16:27 +0200, Simon Wunderlich wrote: > > > On Thu, Jun 27, 2013 at 02:59:00PM +0200, Johannes Berg wrote: > > > > On Thu, 2013-06-27 at 14:44 +0200, Simon Wunderlich wrote: > > > > > > > > > static void ath_rate_init(void *priv, struct ieee80211_supported_band *sband, > > > > > + struct cfg80211_chan_def *chandef, > > > > > > > > I'd argue you can remove the sband pointer now, since the band is known > > > > from the chandef? > > > > > > Not really, these rate algos usually access sband->bitrates, and sband can not be > > > derived from just the band and these others parameters (at least I miss to see how). > > > > sband = hw->wiphy->bands[chandef->chan.band]; > > might be more efficient to just pass it though :) > > johannes Not all RCs have hw saved in their private storage, e.g. PID does not. Anyway, I'd opt for the lazy approach and leave it like that, effiency is a good argument. ;) Cheers, Simon
Attachment:
signature.asc
Description: Digital signature
