On Sunday 03 February 2008, Johannes Berg wrote: > > > When the driver registers a IEEE80211_BAND_2GHZ band, > > it can either be 802.11b or 802.11g. But when 802.11b rates > > are registered "want" will be 3 (since 4 rates are being registered, > > and each of those 4 rates will decrease "want"). > > Huh, yeah, you're right, this is a thinko. > > > - WARN_ON(want != 0 && want != 6); > > + WARN_ON(want != 0 && want != 3 && want != 6); > > However, I think it should just be > > WARN_ON(want != 0 && want != 3); > > 6 just doesn't make sense, does it? Well from your code it seemed that you only made 1Mbit mandatory for 802.11b. So if you want to make all b rates mandatory then the 6 check should indeed be removed. But shouldn't the 2Mbit, 5.5Mbit and 11Mbit set as IEEE80211_RATE_MANDATORY_B as well? Ivo - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
