Hi Gabor,
Sent from my iPad
On 22 jun. 2013, at 17:42, Gabor Juhos <juhosg@xxxxxxxxxxx> wrote:
> Signed-off-by: Gabor Juhos <juhosg@xxxxxxxxxxx>
> ---
> drivers/net/wireless/rt2x00/rt2800lib.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index f4cd3d8..664e9e1 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -2684,12 +2684,26 @@ static void rt2800_config_channel(struct rt2x00_dev *rt2x00dev,
> rf->channel > 14);
> rt2x00_set_field32(&tx_pin, TX_PIN_CFG_PA_PE_G1_EN,
> rf->channel <= 14);
> +
> + if (rt2x00dev->default_ant.tx_chain_num > 2) {
> + /* Turn on tertiary PAs for 3T devices */
> + rt2x00_set_field32(&tx_pin, TX_PIN_CFG_PA_PE_A2_EN,
> + rf->channel > 14);
> + rt2x00_set_field32(&tx_pin, TX_PIN_CFG_PA_PE_G2_EN,
> + rf->channel <= 14);
> + }
> }
>
> if (rt2x00dev->default_ant.rx_chain_num > 1) {
> /* Turn on secondary LNAs for 2R and for 3R devices */
> rt2x00_set_field32(&tx_pin, TX_PIN_CFG_LNA_PE_A1_EN, 1);
> rt2x00_set_field32(&tx_pin, TX_PIN_CFG_LNA_PE_G1_EN, 1);
> +
> + if (rt2x00dev->default_ant.rx_chain_num > 2) {
> + /* Turn on tertiary LNAs for 3R devices */
> + rt2x00_set_field32(&tx_pin, TX_PIN_CFG_LNA_PE_A2_EN, 1);
> + rt2x00_set_field32(&tx_pin, TX_PIN_CFG_LNA_PE_G2_EN, 1);
> + }
> }
Stylistic I would prefer the if outside of if block you included it in.
Something like:
if (tx_chain_num > 2) {
/* Turn on tertiary PAs for 3T devices */
}
if (tx_chain_num > 1) {
/* Turn on secondary PAs for 2T and for 3T devices */
}
/* Turn on primary PAs for 1T, 2T and for 3T devices */
At least to me this is easier to read.
Alternatively it could be changed to a switch statement wit fall-through cases for the number of RX/TX streams.
>
> rt2x00_set_field32(&tx_pin, TX_PIN_CFG_LNA_PE_A0_EN, 1);
> --
> 1.7.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
