This patch fixes a negative array index spotted by the Coverity checker. Signed-off-by: Adrian Bunk <bunk@xxxxxxxxxx> --- I'm not 100% sure whether my patch is correct, but if not this patch is the easiest way to show the problem. --- linux-2.6/drivers/net/wireless/ath5k/phy.c.old 2008-02-02 21:44:58.000000000 +0200 +++ linux-2.6/drivers/net/wireless/ath5k/phy.c 2008-02-02 21:48:28.000000000 +0200 @@ -1176,10 +1176,13 @@ static int ath5k_hw_rf5112_rfregs(struct obdb = channel->freq >= 5725 ? 3 : (channel->freq >= 5500 ? 2 : (channel->freq >= 5260 ? 1 : (channel->freq > 4000 ? 0 : -1))); + if (obdb == -1) + return -EINVAL; + if (!ath5k_hw_rfregs_op(rf, ah->ah_offset[6], ee->ee_ob[ee_mode][obdb], 3, 279, 0, true)) return -EINVAL; if (!ath5k_hw_rfregs_op(rf, ah->ah_offset[6], - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
