Search Linux Wireless

Re: [PATCHv3 05/18] mac80211: fix timing for 5 MHz and 10 MHz channels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 18, 2013 at 04:21:23PM +0200, Johannes Berg wrote:
> 
> > +static inline int
> > +ieee80211_hw_get_divisor(struct ieee80211_hw *hw)
> > +{
> > +	switch (hw->conf.chandef.width) {
> > +	case NL80211_CHAN_WIDTH_5:
> > +		return 4;
> > +	case NL80211_CHAN_WIDTH_10:
> > +		return 2;
> > +	default:
> > +		return 1;
> > +	}
> > +}
> 
> Using this function will break with drivers that use channel contexts,
> you really shouldn't do that.
Hmm ... yeah, you are right. I've used this a lot in the following patches, argh.

Will find another solution.

> 
> Also, you're disabling HT so why bother changing minstrel_ht?

Mhm, yeah that is probably not neccesary. I'll remove that, however we remember
it once HT support should be added. ;)

Thanks,
	Simon

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux