On Mon, 2013-06-17 at 14:32 -0700, greearb@xxxxxxxxxxxxxxx wrote: > static void ieee80211_destroy_assoc_data(struct ieee80211_sub_if_data *sdata, > - bool assoc) > + bool assoc, bool put_bss) Do we _really_ need another argument? Shouldn't it always be put in the non-assoc case anyway, at least if non-NULL? > @@ -2415,6 +2415,10 @@ static void ieee80211_destroy_assoc_data(struct ieee80211_sub_if_data *sdata, > ieee80211_vif_release_channel(sdata); > } > > + if (put_bss) > + cfg80211_put_bss(sdata->local->hw.wiphy, assoc_data->bss); > + > + just one blank line > + /** bss will be passed back to calling code, and that code must > + * deal with properly putting the reference. > + */ /** is for kernel-doc only > return RX_MGMT_CFG80211_RX_ASSOC; You're working on some pretty old code here ... If you want this to be in stable the patch really needs to be smaller, I think. And for mac80211-next this can't apply. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
