On Tue, 2013-06-18 at 17:07 +0800, Yeoh Chun-Yeow wrote: > In sta_info_get_bss, should it be: > > if ((sta->sdata == sdata && > (sta->sdata->bss && sta->sdata->bss == sdata->bss)) > > in stead of > > if ((sta->sdata == sdata || > (sta->sdata->bss && sta->sdata->bss == sdata->bss)) What would the point be? Then we could just as well make it *only* sta->sdata == sdata and it'd be the same as sta_info_get(). This is intentional for VLAN handling. > Otherwise, it seems that we still manage to get sta pointer even the > bss is NULL. What's the problem with that? But if this is a problem maybe we need to explicitly check for non-NULL? johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
