Given recent events, I'm not sure that this is really acceptable as a fix request. The service bit and endianness in particular don't sound like they are addressing big problems, and the other two don't sound like they are really fixing any regressions either. Can these wait for 3.11? John On Thu, Jun 06, 2013 at 05:20:19PM +0200, Samuel Ortiz wrote: > Hi John, > > This is the 2nd NFC pull request for 3.10. > > I wish this one could have been part of the first one, but we came back from > the NFC plugfest with a few more LLCP fixes: > > - The well known services bitmask was sent with the wrong endianness and with > the first bit not set, which goes against the LLCP specifications. This > won't prevent most use cases and tests to pass, only picky implementations > seem to care about the WKS correctness. > > - We were ignoring RNRs and were sending our pending frames regardless. We > should just re-queue them and send a SYMM instead. > > - Non blocking LLCP connections were not handled properly as we found out > after implementing it from neard. Applications were immediatly woken up with > a SIGHUP and connection failed. This is fixed now, allowing us to have a > fully asynchronous NFC userspace daemon. > > Thanks in advance for pulling them in. > > The following changes since commit cee6dfa25831e0daac52fc582a04a7204f886220: > > Revert "ath9k_hw: Update rx gain initval to improve rx sensitivity" (2013-06-05 10:42:29 -0400) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/sameo/nfc-fixes.git tags/nfc-fixes-3.10-2 > > for you to fetch changes up to fcd335b0010aeafb6e3dfd46360778ce59e1e201: > > NFC: llcp: Fix the well known services endianness (2013-06-06 16:43:51 +0200) > > ---------------------------------------------------------------- > Samuel Ortiz (4): > NFC: llcp: Fix non blocking sockets connections > NFC: llcp: Do not send pending Tx frames when the remote is not ready > NFC: llcp: Set the LLC Link Management well known service bit > NFC: llcp: Fix the well known services endianness > > net/nfc/llcp.h | 1 + > net/nfc/llcp_core.c | 8 ++++++-- > net/nfc/llcp_sock.c | 8 +++++--- > 3 files changed, 12 insertions(+), 5 deletions(-) > -- > Intel Open Source Technology Centre > http://oss.intel.com/ > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
