Search Linux Wireless

Re: [ath5k-devel] [PATCH v2] ath5k: make use of the new rate control API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi all,

>>> 
>>> diff --git a/drivers/net/wireless/ath/ath5k/base.c b/drivers/net/wireless/ath/ath5k/base.c
>>> index 7f702fe..c63759f 100644
>>> --- a/drivers/net/wireless/ath/ath5k/base.c
>>> +++ b/drivers/net/wireless/ath/ath5k/base.c
>>> @@ -1587,6 +1633,8 @@ ath5k_tx_frame_completed(struct ath5k_hw *ah, struct sk_buff *skb,
>>> 
>>> 	ieee80211_tx_info_clear_status(info);
>>> 
>>> +	memcpy(info->status.rates, bf->rates, sizeof(info->status.rates));
>>> +
>>> 	for (i = 0; i < ts->ts_final_idx; i++) {
>>> 		struct ieee80211_tx_rate *r =
>>> 			&info->status.rates[i];
>> Please make sure that either this code is able to deal with a size
>> mismatch of info->status.rates vs. bf->rates, or that it at least fails
>> at compile time if the size of info->status.rate gets changed.
>> 

Good catch, V3 is coming.

Thomas


>> - Felix
>> _______________________________________________
>> ath5k-devel mailing list
>> ath5k-devel@xxxxxxxxxxxxxxx
>> https://lists.ath5k.org/mailman/listinfo/ath5k-devel
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux