-----Original Message----- From: Tomas Winkler [mailto:tomasw@xxxxxxxxx] Sent: Friday, February 01, 2008 3:44 AM To: Chatre, Reinette Cc: linville@xxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx; Abbas, Mohamed Subject: Re: [PATCH 2/2] iwlwifi: set rate_idx correctly from plcp On Feb 1, 2008 7:46 AM, Reinette Chatre <reinette.chatre@xxxxxxxxx> wrote: > From: Mohamed Abbas <mohamed.abbas@xxxxxxxxx> > > rate_idx is derived from plcp information > > Signed-off-by: Mohamed Abbas <mohamed.abbas@xxxxxxxxx> > Signed-off-by: Reinette Chatre <reinette.chatre@xxxxxxxxx> > --- > drivers/net/wireless/iwlwifi/iwl-4965.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/wireless/iwlwifi/iwl-4965.c b/drivers/net/wireless/iwlwifi/iwl-4965.c > index 79545d6..29797db 100644 > --- a/drivers/net/wireless/iwlwifi/iwl-4965.c > +++ b/drivers/net/wireless/iwlwifi/iwl-4965.c > @@ -3546,7 +3546,7 @@ static void iwl4965_rx_reply_rx(struct iwl4965_priv *priv, > (rx_start->phy_flags & RX_RES_PHY_FLAGS_BAND_24_MSK) ? > IEEE80211_BAND_2GHZ : IEEE80211_BAND_5GHZ, > .antenna = 0, > - .rate_idx = iwl4965_hw_get_rate( > + .rate_idx = iwl4965_rate_index_from_plcp( > le32_to_cpu(rx_start->rate_n_flags)), > .flag = 0, > }; > -- > 1.5.3.4 > NACK This should be rate_idx = iwl4965_rate_index_from_plcp(wl4965_hw_get_rate(rx_start->rate_n_flags)) ; iwl4965_hw_get_rate - this one extract plcp from rate_n_flags - also takes care of endinaity Tomas Actually iwl4965_rate_index_from_plcp expect rate and flag data to get the rate index. Mohamed > > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > - To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
