Hi Luciano, On 6 June 2013 17:16, Luciano Coelho <coelho@xxxxxx> wrote: > Hi Sachin, > > On Thu, 2013-06-06 at 14:48 +0530, Sachin Kamat wrote: >> On 29 May 2013 15:48, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote: >> > module_spi_driver() eliminates some boiler plate and makes code >> > simpler. >> > >> > Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx> >> > --- >> > drivers/net/wireless/ti/wl1251/spi.c | 24 +----------------------- >> > 1 file changed, 1 insertion(+), 23 deletions(-) >> > >> > diff --git a/drivers/net/wireless/ti/wl1251/spi.c b/drivers/net/wireless/ti/wl1251/spi.c >> > index 4c67c2f..dfd0877 100644 >> > --- a/drivers/net/wireless/ti/wl1251/spi.c >> > +++ b/drivers/net/wireless/ti/wl1251/spi.c >> > @@ -329,29 +329,7 @@ static struct spi_driver wl1251_spi_driver = { >> > .remove = wl1251_spi_remove, >> > }; >> > >> > -static int __init wl1251_spi_init(void) >> > -{ >> > - int ret; >> > - >> > - ret = spi_register_driver(&wl1251_spi_driver); >> > - if (ret < 0) { >> > - wl1251_error("failed to register spi driver: %d", ret); >> > - goto out; >> > - } >> > - >> > -out: >> > - return ret; >> > -} >> > - >> > -static void __exit wl1251_spi_exit(void) >> > -{ >> > - spi_unregister_driver(&wl1251_spi_driver); >> > - >> > - wl1251_notice("unloaded"); >> > -} >> > - >> > -module_init(wl1251_spi_init); >> > -module_exit(wl1251_spi_exit); >> > +module_spi_driver(wl1251_spi_driver); >> > >> > MODULE_LICENSE("GPL"); >> > MODULE_AUTHOR("Kalle Valo <kvalo@xxxxxxxxxx>"); >> > -- >> > 1.7.9.5 >> > >> >> Gentle ping on this series John. > > This is in my queue. Haven't had the time to review and apply them yet. > And these are not urgent changes, so they can wait a little while. Sure. Thanks. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html