Antonio Quartulli <antonio@xxxxxxxxxxxxx> writes: > On Wed, Jun 05, 2013 at 02:47:01AM -0700, Kalle Valo wrote: >> Antonio Quartulli <ordex@xxxxxxxxxxxxx> writes: >> >> > From: Antonio Quartulli <antonio@xxxxxxxxxxxxx> >> > >> > Users may want to send a frame on the current channel >> > without specifying it. >> > >> > Make mgmt_tx pass a NULL channel to mac80211 if none has >> > been specified by the user. >> > >> > Signed-off-by: Antonio Quartulli <antonio@xxxxxxxxxxxxx> >> >> Why? And what users are we talking about here? It would be nice if the >> commit log would give some context here for use who nothing about this >> patch. "Users may want" is not very informative :) > > Hello Kalle, > thanks for your feedback. > > Sure, I can change the commit log. > > However, I already wrote a couple of (userspace) applications which wanted to > send a message on the current channel and the only way to do it was to first get > the current channel and then pass it when sending a CMD_FRAME via nl80211. Of > course this approach is just a bit racy :-) > > Moreover, I'm currently working on improving IBSS/RSN support in wpa_supplicant > and sending frames on the current channel is needed. > > Do you think it is worth mentioning userspace applications like wpa_s in the > kernel commit message? I don't know what others think, but to me it is. It makes it easier to understand why the change is made. And also do we really need the change or not. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
