On 05/31/2013 09:14 PM, Johannes Berg wrote:
On Fri, 2013-05-31 at 11:51 -0700, Ben Greear wrote:
What I'm saying though is that I don't see where skb->priority is even
_used_ in the wifi stack. I can see it getting set, but not used.
ieee80211_downgrade_queue
wme_downgrade_ac // sort of
ieee80211_select_queue_80211 // sort of...seems twiddling skb->priority is more of a by-product here.
cfg80211_classify8021d
None of this actually matters, it's all within the select_queue() call
so doesn't need to store it in the skb.
I found it though -- the only thing that ever looks at it is
ieee80211_set_qos_hdr() to set the QoS header TID, and presumably that's
what ath9k complains about (hwsim is happy to just push packets.)
Sorry to chime in. The brcmfmac uses cfg80211_classify8021d() as well
(only when skb->priority equals zero) and puts the return value in
skb->priority. But also there it is not needed as a few lines below it
uses it to determine the WWM-AC fifo.
Regards,
Arend
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
