On Sat, May 25, 2013 at 1:20 AM, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > >> > I think you should consider allowing this attribute only if the channel >> > is also specified (NL80211_ATTR_WIPHY_FREQ, parsed below), and not make >> > it nested with rates for both bands but just the selected band. >> > >> Yes, I think by this approach, we eliminate the need for the user to >> provide rates for both bands and also not require to have a per-band >> for basic_rates. >> >> Said that, I am wondering why give mcast_rate for both bands, but >> basic_rates only for one band? > > Heh, good question. I think it was probably copied from IBSS where you > can pick another channel? Doesn't make all that much sense for mesh I > guess, unless MBSS channel switch could cause us to use another channel? > But then presumably you should follow the basic rates from the STA > initiating the switch, or something, since mesh networks are only > compatible with the same basic rates, right? > Yes, that is right. I will come up with a patch now for basic_rates configuration as per your suggestion. Thanks, Ashok > johannes > -- Ashok Raj Nagarajan, cozybit Inc. http://www.cozybit.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html