Search Linux Wireless

Re: [PATCH] mac80211: mesh formation info properly set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2013-05-29 at 12:21 -0700, Jacob Minshall wrote:
> Max peerings capped at 63 in accordance with IEEE-2012 8.4.2.100.7,
> and trigger a beacon regeneration every time the number of peerings
> changes. 

Can you write full sentences? Maybe also in the subject ("set mesh ...
properly"?) :-)


> -	neighbors = (neighbors > 15) ? 15 : neighbors;
> +	neighbors = (neighbors > IEEE80211_MAX_MESH_PEERINGS) ?
> +			IEEE80211_MAX_MESH_PEERINGS : neighbors;

min() or min_t()?

>  	atomic_inc(&sdata->u.mesh.estab_plinks);
> -	return mesh_accept_plinks_update(sdata);
> +	mesh_accept_plinks_update(sdata);
> +	return BSS_CHANGED_BEACON;

These changes seem odd to me, why doesn't mesh_accept_plinks_update()
just return the change value then?

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux