Search Linux Wireless

Re: [RFC 2/2] cfg80211: separate internal SME implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2013-05-25 at 15:33 +0000, Kondratiev, Vladimir wrote:

> I prepared the patch, need few days to test it and I'll submit.

Thanks.

> I have conceptual question regarding wdev private data.
> Currently, drivers end up duplicating wdev's data internally. I'd say it is better to track, for example,
> SME connection state once. Maybe, it is worth to provide functions to access wdev's data?

Well, with my changes cfg80211 is no longer tracking the state at all,
unless you're using the cfg80211 SME, which your driver can't even use
since it doesn't implement auth/assoc but connect(). So in that sense,
there's no duplication.

I suppose you could argue that cfg80211 could track whether it was
already connected or not and call cfg80211_connect_result() is you
disconnect while never even connected, and it actually does still track
this (wdev->current_bss). OTOH, you could also argue that a firmware API
that requires tracking this on the host is broken ;-)

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux