Search Linux Wireless

Re: [PATCH 1/3] mac80211: add STBC flag for radiotap

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2013-05-19 at 09:38 +0200, Oleksij Rempel wrote:

> + * @RX_FLAG_STBC_MASK: STBC 2 bit bitmask. 1 - Nss=1, 2 - Nss=2, 3 - Nss=3

> +	RX_FLAG_STBC_MASK		= BIT(26) | BIT(27),



> @@ -258,6 +258,7 @@ ieee80211_add_rx_radiotap_header(struct ieee80211_local *local,
>  	pos += 2;
>  
>  	if (status->flag & RX_FLAG_HT) {
> +		unsigned int stbc = status->flag & RX_FLAG_STBC_MASK;
>  		rthdr->it_present |= cpu_to_le32(1 << IEEE80211_RADIOTAP_MCS);
>  		*pos++ = local->hw.radiotap_mcs_details;
>  		*pos = 0;
> @@ -267,6 +268,9 @@ ieee80211_add_rx_radiotap_header(struct ieee80211_local *local,
>  			*pos |= IEEE80211_RADIOTAP_MCS_BW_40;
>  		if (status->flag & RX_FLAG_HT_GF)
>  			*pos |= IEEE80211_RADIOTAP_MCS_FMT_GF;
> +		if (stbc)
> +			*pos |= (stbc >> RX_FLAG_STBC_SHIFT)
> +					<< IEEE80211_RADIOTAP_MCS_STBC_SHIFT;
>  		pos++;
>  		*pos++ = status->rate_idx;

Here you forgot the "HAVE" bit.


> -			 IEEE80211_RADIOTAP_MCS_HAVE_BW;
> +			 IEEE80211_RADIOTAP_MCS_HAVE_BW |
> +			 IEEE80211_RADIOTAP_MCS_HAVE_STBC;

And here it's completely bogus.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux