Hi Luis, Thanks for your comments. > > From: Amitkumar Karwar <akarwar@xxxxxxxxxxx> > > > > Add set/get configuration support for packet coalesce. > > > > This feature needs to be advertised during driver initialization. > > Drivers can do required hardware settings based on user configuration. > > > > Signed-off-by: Amitkumar Karwar <akarwar@xxxxxxxxxxx> > > Signed-off-by: Bing Zhao <bzhao@xxxxxxxxxxx> > > I see nothing documenting clearly what this "coalesce" does. > Can you elaborate quite a bit both on the commit log and also > the documentation on nl80211.h what this is exactly? will add the documentations in v2. > It would also be good for you to express on your previous patch why > you want the rename. "packet coalesce" will reuse the pattern structure (and its enum definitions) defined for WoWLAN. It's renamed so that both WoWLAN and Coalesce can make use of it. More elaborations will be added in v2 series. > > If you add this also can you please be sure to update the wiki > for iw to document support for this? Sure. It will be done as soon as the iw patches are merged. Thanks, Bing > > Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
